feat: add both default and named export #5
Conversation
|
The change is legit but wonder why you have the issue, also saw you’re using |
I don't know, but I guess it is caused by how rollup bundles the
|
|
Ah looks like the official plugins are using a trick like Which we don't have it, and |
src/index.ts
Outdated
| @@ -14,7 +14,7 @@ interface PreserveDirectiveMeta { | |||
| directives: Record<string, Set<string>> | |||
| } | |||
|
|
|||
| export default function swcPreserveDirectivePlugin(): Plugin { | |||
| export function swcPreserveDirective(): Plugin { | |||
There was a problem hiding this comment.
| export function swcPreserveDirective(): Plugin { | |
| function swcPreserveDirective(): Plugin { |
There was a problem hiding this comment.
Done in adee1ff (#5).
src/index.ts
Outdated
| @@ -103,3 +103,5 @@ export default function swcPreserveDirectivePlugin(): Plugin { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| export default swcPreserveDirective | |||
There was a problem hiding this comment.
I think we can create a named export with a shorter name just other rollup plugins
| export default swcPreserveDirective | |
| export default swcPreserveDirective | |
| export { swcPreserveDirective as preserveDirective } |
There was a problem hiding this comment.
Done in adee1ff (#5).
huozhi
changed the title
The default export breaks
rollup -c rollup.config.ts --configPlugin swc3 --bundleConfigAsCjs: https://github.com/SukkaW/foxact/actions/runs/5567493053/jobs/10169409656The PR adds both named export and default export.