Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Background Unchanged when 2 Consecutive Entry Screen Backgrounds Match #46

Closed
huri000 opened this issue Jun 8, 2018 · 1 comment
Closed

Keep Background Unchanged when 2 Consecutive Entry Screen Backgrounds Match #46

huri000 opened this issue Jun 8, 2018 · 1 comment
Assignees
@huri000
Labels
enhancement New feature or request

Comments

@huri000
Copy link
Owner

huri000 commented Jun 8, 2018

Is your feature request related to a problem? Please describe.
When an entry is displayed and another entry is pushed in, the background of the first entry animates out before the new entry is displayed. In case both entries have the same background configuration, the previous background should not animate out in order to generate continuity.

Describe the solution you'd like

  • Add Equatable protocol to EKAttributes.BackgroundStyle and implement ==.
  • In EKRootViewController, before animating the previous entry out, check for background-style equality.
@huri000 huri000 self-assigned this Jun 8, 2018
@huri000 huri000 added the enhancement New feature or request label Jun 8, 2018
@huri000 huri000 changed the title Keep Entry Screen Background Unchanged When 2 Consecutive Entries' Background Match Keep Background Unchanged when 2 Consecutive Entries Background Match Jun 8, 2018
@huri000 huri000 changed the title Keep Background Unchanged when 2 Consecutive Entries Background Match Keep Background Unchanged when 2 Consecutive Entry Screen Backgrounds Match Jun 8, 2018
huri000 added a commit that referenced this issue Jun 8, 2018
@huri000
Keep Background Unchanged when 2 Consecutive Entry Screen Backgrounds…
39d367d 
… Match #46
@huri000 huri000 mentioned this issue Jun 8, 2018
Merged
@huri000
Copy link
Owner Author

huri000 commented Jun 8, 2018

Resolved in 0.4.1

@huri000 huri000 closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huri000 huri000

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huri000