Cleaner notifications #49
Conversation
|
I've also updated chum:testing with this branch if you want to test, this will be the next release |
| var tryToBeSilent = Qt.application.state == Qt.ApplicationActive; | ||
| var message = notificationComponent.createObject(null, { | ||
| 'previewSummary': tryToBeSilent ? null: qsTr("New hydrogen message."), | ||
| 'isTransient': !appConfig.stickyNotifications, |
There was a problem hiding this comment.
AFAIK, isTransient mainly causes the notification to be a popup, and not show up in the Event view.
The intent of "Sticky" notifications (which only existed as a Setting and were never implemented) was to have a notification on the Event view, but only one, as opposed to a new one each time a notification is triggered.
The handling of lastNotificationId as implemented here should do that, but it may be "defeated" by isTransient - i.e. it may be "sticky" but never reach the Event View because transient.
There was a problem hiding this comment.
That is a very good point - I just re-read the descripton from UI for "Sticky notifications".
In my opinion, since we don't (yet) deliver a notification per room, having them sticky by default is useful at the moment.
With that in mind, I thought that making them transient would be the other option.,
Now: what do you think - should I re-phrase the UI to my changes (e.g "Transient notifications", or actually make lastNotificationId play along only when sticky (and make that the default)? Third option: just remove UI setting and make all sticky for now. Thanks!
There was a problem hiding this comment.
Went with re-purposing transient vs sticky in settings
|
Cool, good riddance to my needlessly overcomplicated version. |
clarifying
As per @nephros' pointers:
Also, when "tryToBeSilent" is true, the notification is still published (count updated) but does not ping you in hydrogen.
Last minute fix: this should honor Sticky notifs settings too.