-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize registry fetch latency #29
Comments
I like option 1 the best because it makes the improved latency available to all registry users, not just those that have custom caching / build-time logic implemented. It's also the easiest to do. |
Snippet from more discord discussion: https://discord.com/channels/935678348330434570/1243986495916736632/1246957837805162669 ...having thought through it more, all the options have downsides. Build-time chain data assembly would require contributors to have the JS tooling (e.g. yarn). PR CI-time requires a github token with write perms, which would complicate things for registry forkers. Ditto for a post-PR-merge CI job. |
In the end I was able to make CI-based updates work well enough. |
### Description Fixes #29 - Add combined chain address and metadata files - Update combined files in build - Add CI job to update combined files on push #### Other notes ### Backward compatibility Yes ### Testing Updated unit tests to exercise new code and files --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Paul Balaji <[email protected]>
### Description Update to latest registry for faster and more efficient chain metadata/address fetching ### Related issues hyperlane-xyz/hyperlane-registry#29 ### Backward compatibility Yes ### Testing Ran CLI registry commands locally
Capturing thoughts from discussion here: https://discord.com/channels/935678348330434570/1238863226419023892
There are many options for ways we can optimize this:
The text was updated successfully, but these errors were encountered: