-
Notifications
You must be signed in to change notification settings - Fork 295
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(typescript): bump tsc globally and switch to nodenext for iroha2
Here are all the changes implemented for moduleResolution to nodeNext and Typescript upgrade ------------------------------------------- 1. Upgraded TypeScript to 4.7.4 globally and switched moduleResolution nodeNext in cactus-plugin-ledger-connector-iroha2 2. Upgraded @typescript-eslint/eslint-plugin & @typescript-eslint/eslint/parser to 5.27.0 so that it supports the newer version of Typescript. 3. Added useUnknownInCatchVariables: false in tsconfig and tsconfig.base.json to fix the errors related to 'unknown' type in catch variables that occurred after upgrading the typescript. 4. Updated rxjs to v7.8.1 globally in all package.json files to match the version in IrohaV2. This is better than adding a resolution in the root package.json because it makes it visible and explicit that we've upgraded the dependency everywhere. The global resolutions override is a last resort option because it is pretty confusing to beginners when they specify a dependency version in their own package.json but it doesn't ever get installed because of the override coming from the top level package.json. The reason the upgrade was needed to begin with: Typescript compiler errors were being caused by the mismatching version of rxjs that the iroha2 client packages depend on vs. the versions that our codebase uses. Now with the upgrade they are in sync and the build passes. --- Secondary change: Peter: I'm sneaking in another hot-fix for the codegen task which makes the .jar download (that's part of the warmup script) SEQUENTIAL instead of having it PARALLEL which appeared to be working fine earlier but it no longer seems to be the case, e.g., I've seen some race condition looking errors pop up after having merged the PR with the earlier hotfix. The root cause of the issue likely the openapi-generator-cli package itself not being safe for concurrent use in general, but a full audit of that code would have to be performed to validate this theory. For now it is just easier to set it to SEQUENTIAL and be done with it (hopefully) Fixes #2158 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: aldousalvarez <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
- Loading branch information
1 parent
e52942e
commit 6742817
Showing
19 changed files
with
122 additions
and
134 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.