Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: install secret detection on pre-commit hooks #2290

Closed
petermetz opened this issue Feb 16, 2023 · 1 comment · Fixed by #3606
Closed

chore: install secret detection on pre-commit hooks #2290

petermetz opened this issue Feb 16, 2023 · 1 comment · Fixed by #3606
Assignees
@zondervancalvez
Labels
Security Related to existing or potential security vulnerabilities

Comments

@petermetz
Copy link
Contributor

petermetz commented Feb 16, 2023 •
edited by jagpreetsinghsasan
Loading

to catch secret before it leaves your machine and ease remediation.

Description

As a developer, I want to incorporate a check so that any secrets/crypto doesn't get pushed to the github repo and this check runs as a part of pre-commit check

Acceptance Criteria

  1. Test should be done by incorporating various credentials/secrets like github secrets, aws secrets, pem files, access tokens
@zondervancalvez
Copy link
Contributor

@jagpreetsinghsasan Please assign this to me. Thank you

@jagpreetsinghsasan jagpreetsinghsasan added the Security Related to existing or potential security vulnerabilities label Oct 7, 2024
@jagpreetsinghsasan jagpreetsinghsasan moved this from Todo to In Progress in Cacti_Scrum_Project_v2_Release Oct 8, 2024
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 29, 2024
@zondervancalvez
chore: install secret detection on pre-commit hooks
b746d1c 
Primary Changes
----------------
1. Installed gitleaks for secret detection.
2. This pre-commit checker detects any secrets
or crypto so that it doesn't get pushed to
the github repo.

Fixes hyperledger-cacti#2290
@zondervancalvez zondervancalvez mentioned this issue Oct 29, 2024
Merged
5 tasks
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Oct 29, 2024
@zondervancalvez
chore: install secret detection on pre-commit hooks
f7ffe95 
Primary Changes
----------------
1. Installed gitleaks for secret detection.
2. This pre-commit checker detects any secrets
or crypto so that it doesn't get pushed to
the github repo.

Fixes hyperledger-cacti#2290
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Nov 20, 2024
@zondervancalvez
chore: install secret detection on pre-commit hooks
a62bd91 
Primary Changes
----------------
1. Installed gitleaks for secret detection.
2. This pre-commit checker detects any secrets
or crypto so that it doesn't get pushed to
the github repo.
3. Added script to run install and uninstall
the pre-commit hooks in package.json

Fixes hyperledger-cacti#2290

Signed-off-by: bado <[email protected]>
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Dec 4, 2024
@zondervancalvez
chore: install secret detection on pre-commit hooks
ac981c7 
Primary Changes
----------------
1. Installed gitleaks for secret detection.
2. This pre-commit checker detects any secrets
or crypto so that it doesn't get pushed to
the github repo.
3. Added script to run install and uninstall
the pre-commit hooks in package.json

Fixes hyperledger-cacti#2290

Signed-off-by: bado <[email protected]>
petermetz pushed a commit to zondervancalvez/cactus that referenced this issue Dec 5, 2024
@zondervancalvez @petermetz
chore: install secret detection on pre-commit hooks
f3bb85a 
Primary Changes
----------------
1. Installed gitleaks for secret detection.
2. This pre-commit checker detects any secrets
or crypto so that it doesn't get pushed to
the github repo.
3. Added script to run install and uninstall
the pre-commit hooks in package.json

Fixes hyperledger-cacti#2290

Signed-off-by: bado <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cacti_Scrum_Project_v2_Release Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zondervancalvez zondervancalvez

Labels
Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: install secret detection on pre-commit hooks zondervancalvez/cactus
3 participants
@petermetz @jagpreetsinghsasan @zondervancalvez