-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(openapi): phase 2 - generate kotlin clients #2272
build(openapi): phase 2 - generate kotlin clients #2272
Conversation
7337571
to
64069eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan Sorry for the slow review!
Please change a couple of things:
- Add the ./docs folders of the generated code to the openapi-generator-ignore file so that those files are not in the diff. It's cool that we have these generated markdown files but the same docs can be generated at runtime in a much nicer format directly from the open api specs we use so I'd rather just cut down on the diff size, number of files in the repo, etc. wherever possible.
- IF it does not break the build then also ignore all the added ./gradle/wrapper/ folders that have all those jars. Similar reasoning as above. Gradle is already a dependency for the build anyway so the wrapper is just taking up space and committing compiled code should be avoided whenever it's not absolutely unavoidable (especially because we would be committing the same jar many times over)
Other than these, it LGTM, thank you!
64069eb
to
687ccec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan LGTM, thank you for the updates!
Primary Changes -------------- 1. Updated package.json files of several packages to include kotlin code generation script 2. Updated the ghpkg-all-kotlin-api-clients-publish.yaml to include the plugins updated in 1) package.json updated for the following plugins to incorporate 1) ---------------------------------------------------------------- a. packages/cactus-cmd-api-server b. packages/cactus-core-api c. packages/cactus-plugin-consortium-manual d. packages/cactus-plugin-keychain-aws-sm e. packages/cactus-plugin-keychain-azure-kv f. packages/cactus-plugin-keychain-google-sm g. packages/cactus-plugin-keychain-memory h. packages/cactus-plugin-keychain-memory-wasm i. packages/cactus-plugin-keychain-vault j. packages/cactus-plugin-ledger-connector-fabric k. packages/cactus-plugin-odap-hermes l. examples/cactus-example-carbon-accounting-business-logic-plugin m. examples/cactus-example-supply-chain-business-logic-plugin n. extensions/cactus-plugin-object-store-ipfs package.json updated for future incorporation of 1) -------------------------------------------------- a. packages/cactus-plugin-htlc-eth-besu b. packages/cactus-plugin-htlc-eth-besu-erc20 c. packages/cactus-plugin-ledger-connector-iroha d. packages/cactus-plugin-ledger-connector-iroha2 e. packages/cactus-plugin-ledger-connector-quorum f. packages/cactus-plugin-ledger-connector-xdai g. extensions/cactus-plugin-htlc-coordinator-besu Fixes hyperledger-cacti#468 Signed-off-by: jagpreetsinghsasan <[email protected]>
687ccec
to
658a0f3
Compare
Commit to be reviewed
build(openapi): phase 2 - generate kotlin clients
Fixes #468
Signed-off-by: jagpreetsinghsasan [email protected]