style: changes made for fixing #1357 #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnabnandikgp
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
@arnabnandikgp Thank you very much for the contribution!
If you can, please make sure to sync the commit message to the PR description because right now it's only the PR description that holds the relevant information but not the commit message body.
The issue with this is that the PR description is in the internal database of GitHub and is not something that we have direct access to the same way we do for the actual git commit messages so it's best to keep those two in sync.
If you need any help with git mechanics just let me know!
Signed-off-by: Arnab Nandi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submitting fixes for issue #1357 minus the linter warning ID 79 and 80 as they have been already solved in batch 9 #1478.
I have added types of variables and objects wherever necessary in place of 'any' and for packages/cactus-common/src/test/typescript/unit/logging/logger.test.ts I have declared a interface for prototyping the stdOutDataHandler function.
fixes #1357
Signed-off-by: Arnab Nandi [email protected]