add-ledgerId field in validator #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2017 21:36
Signed-off-by: Lovesh <[email protected]>
Signed-off-by: Lovesh <[email protected]>
| @@ -55,6 +56,7 @@ class ClientNYMOperation(MessageValidator): | |||
| class ClientGetTxnOperation(MessageValidator): | |||
| schema = ( | |||
| (TXN_TYPE, ConstantField(GET_TXN)), | |||
| (f.LEDGER_ID.nm, LedgerIdField()), | |||
There was a problem hiding this comment.
Adding a new field breaks backward compatibility, isn't it?
There was a problem hiding this comment.
Please make it optional
Signed-off-by: Lovesh <[email protected]>
| @@ -9,24 +11,48 @@ | |||
| op_get_txn = ClientGetTxnOperation() | |||
|
|
|||
|
|
|||
| def test_small_seq_no_fails(): | |||
| def test_no_ledgerId_fails(): | |||
There was a problem hiding this comment.
It should be test_no_ledgerId_succeeds
ashcherbakov
approved these changes
Nov 27, 2017
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Nov 28, 2017
* add-ledgerId field in validator Signed-off-by: Lovesh <[email protected]> * uncommenting Signed-off-by: Lovesh <[email protected]> * making ledger id optional Signed-off-by: Lovesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lovesh [email protected]