Sdk to tests #469
Merged
Sdk to tests #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
…naure field in request serialization Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
helper and test_catchup_during_3pc
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Public/indy 901
Signed-off-by: Dmitry Surnin <[email protected]>
…k-to-tests Signed-off-by: Dmitry Surnin <[email protected]>
Signed-off-by: Dmitry Surnin <[email protected]>
andkononykhin
suggested changes
Dec 5, 2017
plenum/test/helper.py
Outdated
| from plenum.test.test_client import TestClient, genTestClient | ||
| from plenum.test.test_node import TestNode, TestReplica, TestNodeSet, \ | ||
| checkNodesConnected, ensureElectionsDone, NodeRef, getPrimaryReplica | ||
| from stp_core.common.log import getlogger | ||
| from stp_core.loop.eventually import eventuallyAll, eventually | ||
| from stp_core.loop.looper import Looper | ||
| from stp_core.network.util import checkPortAvailable | ||
| from typing import Sequence |
There was a problem hiding this comment.
could you move that into the upper import statement for 'typing'?
plenum/test/helper.py
Outdated
| from plenum.test.test_client import TestClient, genTestClient | ||
| from plenum.test.test_node import TestNode, TestReplica, TestNodeSet, \ | ||
| checkNodesConnected, ensureElectionsDone, NodeRef, getPrimaryReplica | ||
| from stp_core.common.log import getlogger | ||
| from stp_core.loop.eventually import eventuallyAll, eventually | ||
| from stp_core.loop.looper import Looper | ||
| from stp_core.network.util import checkPortAvailable | ||
| from typing import Sequence | ||
| from plenum.common.constants import CURRENT_PROTOCOL_VERSION |
plenum/test/helper.py
Outdated
| from typing import Sequence | ||
| from plenum.common.constants import CURRENT_PROTOCOL_VERSION | ||
| from plenum.common.request import Request | ||
| import json |
There was a problem hiding this comment.
could you move that to the beginning of the file where all global imports are defined?
plenum/test/helper.py
Outdated
| import json | ||
| from indy.ledger import sign_and_submit_request, sign_request, submit_request, build_nym_request | ||
| from indy.error import ErrorCode, IndyError | ||
| import asyncio |
| rem = num_reqs % num_batches | ||
| if rem == 0: | ||
| rem = num_reqs // num_batches | ||
| sdk_resps.extend(sdk_send_random_and_check(looper, txnPoolNodeSet, sdk_pool, sdk_wallet, rem, **kwargs)) |
There was a problem hiding this comment.
seems in current logic we will send num_batches + 1. also rem==0 is also is not checked
There was a problem hiding this comment.
it is ok
range - 1 generates num_batches -1 sends
the last chunk contains less or equal reqs, so last send will contain full batch or less txns
| @@ -70,6 +64,8 @@ def testRequestDynamicValidation(tconf, looper, txnPoolNodeSet, | |||
| REJECT is sent to the client | |||
| :return: | |||
| """ | |||
| # Change this test for using SDK. | |||
There was a problem hiding this comment.
please, add TODO mark
plenum/test/conftest.py
Outdated
| @@ -58,6 +58,12 @@ | |||
| from plenum.test.test_node import TestNode, TestNodeSet, Pool, \ | |||
| checkNodesConnected, ensureElectionsDone, genNodeReg | |||
| from plenum.common.config_helper import PConfigHelper, PNodeConfigHelper | |||
| import json | |||
There was a problem hiding this comment.
please, move that to the beginning of the file
Signed-off-by: Dmitry Surnin <[email protected]>
andkononykhin
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.