[INDY-1116] fix IstanceChanges queue cleanup while view change completed #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could one of the committers please verify this patch? |
| # by msg.view_no. When view change was occured and view_no is changed, | ||
| # then we should delete all INSTANCE_CHANGE messages with current (already changed) | ||
| # view_no (which used in corresponded INSTANCE_CHANGE messages) | ||
| self.instanceChanges.pop(self.view_no, None) |
There was a problem hiding this comment.
I think we can remove all instance changes with view_no <= self.view_no as we do for self._next_view_indications
lampkin-diet
force-pushed
the
public/indy-1116
branch
from
cb9f506 to
0febf93
Compare
Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet
force-pushed
the
public/indy-1116
branch
from
0febf93 to
9dbd998
Compare
andkononykhin
previously approved these changes
Feb 5, 2018
Signed-off-by: Andrew Nikitin <[email protected]>
andkononykhin
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Nikitin [email protected]