[INDY-1206] select_primaries now called after poolLedger catchup or if we are ordering node txn #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 23, 2018 18:14
…f we are ordering node txn Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
plenum/server/node.py
Outdated
| @@ -1800,6 +1804,8 @@ def allLedgersCaughtUp(self): | |||
| .format(CATCH_UP_PREFIX, self), | |||
| extra={'cli': True}) | |||
| self.no_more_catchups_needed() | |||
| # select primaries after pool ledger caughtup | |||
| self.select_primaries() | |||
There was a problem hiding this comment.
Should we check if view_change_in_progress is False?
There was a problem hiding this comment.
Or maybe we can check if the expected number of replicas is greater than the current one?
Signed-off-by: Andrew Nikitin <[email protected]>
ashcherbakov
approved these changes
Mar 26, 2018
|
test this please |
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 9, 2018
…f we are ordering node txn (hyperledger#588) * [INDY-1206] select_primaries now called after poolLedger catchup or if we are ordering node txn Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1206] Rollback postTxnFromCatchupAddedToLedger logic Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1206] Move select_primaries() to AllLedgersCaughtup Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1206] Added view_change_in_progress check Signed-off-by: Andrew Nikitin <[email protected]>
lampkin-diet
pushed a commit
to lampkin-diet/indy-plenum
that referenced
this pull request
Apr 10, 2018
…f we are ordering node txn (hyperledger#588) * [INDY-1206] select_primaries now called after poolLedger catchup or if we are ordering node txn Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1206] Rollback postTxnFromCatchupAddedToLedger logic Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1206] Move select_primaries() to AllLedgersCaughtup Signed-off-by: Andrew Nikitin <[email protected]> * [INDY-1206] Added view_change_in_progress check Signed-off-by: Andrew Nikitin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Nikitin [email protected]