Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INDY-1251: fix data in notifier plugin tests and unskip them. #647

Merged
merged 1 commit into from
Apr 27, 2018
Merged

INDY-1251: fix data in notifier plugin tests and unskip them. #647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions plenum/test/plugin/test_notifier_plugin_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def testPluginManagerSendMessageUponSuspiciousSpike(
assert sent == 3


@pytest.mark.skip(reason='INDY-1251')
def testNodeSendNodeRequestSpike(pluginManagerWithImportedModules, testNode):
def mockProcessRequest(obj, inc=1):
obj.nodeRequestSpikeMonitorData['accum'] += inc
Expand All @@ -134,14 +133,13 @@ def mockProcessRequest(obj, inc=1):
assert testNode.sendNodeRequestSpike() is None
mockProcessRequest(testNode, 2)
assert testNode.sendNodeRequestSpike() is None
mockProcessRequest(testNode, 10)
mockProcessRequest(testNode, 8)
assert testNode.sendNodeRequestSpike() is None
mockProcessRequest(testNode, 100)
sent, found = testNode.sendNodeRequestSpike()
assert sent == 3


@pytest.mark.skip(reason='INDY-1251')
def testMonitorSendClusterThroughputSpike(pluginManagerWithImportedModules,
testNode):
N = 15
Expand All @@ -159,7 +157,7 @@ def testMonitorSendClusterThroughputSpike(pluginManagerWithImportedModules,
assert testNode.monitor.sendClusterThroughputSpike() is None
testNode.monitor.clusterThroughputSpikeMonitorData['accum'] = [2]
assert testNode.monitor.sendClusterThroughputSpike() is None
testNode.monitor.clusterThroughputSpikeMonitorData['accum'] = [4, 6]
testNode.monitor.clusterThroughputSpikeMonitorData['accum'] = [7, 9]
assert testNode.monitor.sendClusterThroughputSpike() is None
testNode.monitor.clusterThroughputSpikeMonitorData['accum'] = [100]
sent, found = testNode.monitor.sendClusterThroughputSpike()
Expand Down