Fix browser support check failure if boot script loaded before body #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a false negative in the test for whether the current browser is supported if the Hypothesis boot script is included in the `<head>` of the page (before the `<body>`). In this case `document.body` is `null`.
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 200 200
Lines 7486 7486
Branches 1643 1643
=======================================
Hits 7316 7316
Misses 170 170
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a sporadic (?) false negative in the test for whether the current browser is
supported if the Hypothesis boot script is included in the
<head>ofthe page (before the
<body>). In this casedocument.bodyisnull. This can happen in Via when viewing an HTML page (not a PDF).Given the problem I'd expect it to be consistently reproducible in all browsers, however that appeared not to be the case in practice. See Slack thread.
In any case, I was able to reproduce a failure when visiting https://via.hypothes.is/https://embed.la.utexas.edu/txlatin/2019/03/05/a-trip-to-the-underworld/ in Firefox 82 and Safari 14.