Update style of filter toggle buttons #6106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6106 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 265 265
Lines 10207 10210 +3
Branches 2465 2467 +2
=======================================
+ Hits 10151 10154 +3
Misses 56 56 ☔ View full report in Codecov by Sentry. |
robertknight
force-pushed
the
filter-pill-buttons
branch
from
2cca4f2 to
2c26b4f
Compare
acelaya
approved these changes
Jan 17, 2024
Comment on lines
43
to
49
| icon, | ||
| description, | ||
| active, | ||
| setActive, | ||
| testId, | ||
| }: FilterToggleProps) { | ||
| const IconComponent = icon; |
There was a problem hiding this comment.
Perhaps you can alias it inline when unpacking the props. If I remember correctly, we use that pattern frequently in frontend-shared.
Suggested change
| icon, | |
| description, | |
| active, | |
| setActive, | |
| testId, | |
| }: FilterToggleProps) { | |
| const IconComponent = icon; | |
| icon: IconComponent, | |
| description, | |
| active, | |
| setActive, | |
| testId, | |
| }: FilterToggleProps) { |
There was a problem hiding this comment.
Good point. Will do.
Update style of filter toggle buttons to align them with the current mocks. Also fix accessibility of the pressed state by using the `pressed` button prop to indicate whether the toggle is active. Part of #6006.
robertknight
force-pushed
the
filter-pill-buttons
branch
from
2c26b4f to
9820efb
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update style of filter toggle buttons to align them with the current mocks.
Also fix accessibility of the pressed state by using the
pressedbutton propto indicate whether the toggle is active.
Part of #6006.
Filter active:
This should use a minus rather than a plus icon, but we don't have one in the pattern library yet. I will add that and update this.
Filter inactive: