Report tab count changes to screen readers #6128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the new search UI there is no longer a status message which tries to describe the search result counts in detail. Instead we rely on the existing counts that are displayed on tab titles. Add a hidden status message with `role="status", aria-live="polite"` to communicate changes in these counts to assistive technology users. Part of #6006
acelaya
approved these changes
Jan 22, 2024
Comment on lines
129
to
137
| if (annotationCount > 0) { | ||
| tabCountsSummaryPieces.push(`${annotationCount} annotations`); | ||
| } | ||
| if (noteCount > 0) { | ||
| tabCountsSummaryPieces.push(`${noteCount} notes`); | ||
| } | ||
| if (orphanCount > 0) { | ||
| tabCountsSummaryPieces.push(`${orphanCount} orphans`); | ||
| } |
There was a problem hiding this comment.
Maybe it's worth handling singular/plural forms for annotation/s, note/s and orphan/s, depending on the values being 1 or greater than 1.
I reckon you created a simple pluralization function some time ago that could be used here, but an inline ternary would be also fine, I think.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 265 265
Lines 10225 10239 +14
Branches 2475 2481 +6
=======================================
+ Hits 10169 10183 +14
Misses 56 56 ☔ View full report in Codecov by Sentry. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new search UI there is no longer a status message which tries to describe the search result counts in detail. Instead we rely on the existing counts that are displayed on tab titles.
Add a hidden status message with
role="status", aria-live="polite"to communicate changes in these counts to assistive technology users.Part of #6006
Testing: