Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Target Bug] FlywooF745Nano - Wrong Motor Resource. #9899

Closed
ramiss opened this issue Apr 6, 2024 · 10 comments · Fixed by #9990
Closed

[Target Bug] FlywooF745Nano - Wrong Motor Resource. #9899

ramiss opened this issue Apr 6, 2024 · 10 comments · Fixed by #9990
Labels

Comments

@ramiss
Copy link

ramiss commented Apr 6, 2024

Current Behavior

  • Critical: The motor on pin C09 is not the correct pin for the FC to ESC stack connector - making this target useless.
  • Nice to have: All of the motors have the wrong assignment, which also makes it annoying.

Steps to Reproduce

  1. Flash the FlywooF745nano target on an F745 nano FC
  2. Test Motors
  3. Motor on pin C09 does not spin because it is actually on pin E09 (see below)

cli motor resources from iNav:
B00: MOTOR3 OUT
B01: MOTOR1 OUT
C09: MOTOR2 OUT <- Wrong pin
E11: MOTOR4 OUT

Expected behavior

All motors should spin

Suggested solution(s)

  1. Correct the motor resources to the following pins (as confirmed in the working BF target and tested by me):

resource MOTOR 1 B00
resource MOTOR 2 B01
resource MOTOR 3 E09 <- the motor on C09 needs to be on E09 (perhaps this was a typo?)
resource MOTOR 4 E11

Additional context

For reference, here is the correct resource assignments from BF:
resource BEEPER 1 D15
resource MOTOR 1 B00
resource MOTOR 2 B01
resource MOTOR 3 E09
resource MOTOR 4 E11
resource MOTOR 5 C09
resource MOTOR 6 A03
resource MOTOR 7 B04
resource MOTOR 8 B05
resource LED_STRIP 1 D12
resource SERIAL_TX 1 A09
resource SERIAL_TX 2 D05
resource SERIAL_TX 3 D08
resource SERIAL_TX 4 A00
resource SERIAL_TX 5 C12
resource SERIAL_TX 6 C06
resource SERIAL_TX 7 E08
resource SERIAL_RX 1 A10
resource SERIAL_RX 2 D06
resource SERIAL_RX 3 D09
resource SERIAL_RX 4 A01
resource SERIAL_RX 5 D02
resource SERIAL_RX 6 C07
resource SERIAL_RX 7 E07
resource I2C_SCL 1 B06
resource I2C_SCL 2 B10
resource I2C_SDA 1 B07
resource I2C_SDA 2 B11
resource LED 1 A02
resource SPI_SCK 1 A05
resource SPI_SCK 2 B13
resource SPI_SCK 4 E02
resource SPI_SDI 1 A06
resource SPI_SDI 2 B14
resource SPI_SDI 4 E05
resource SPI_SDO 1 A07
resource SPI_SDO 2 B15
resource SPI_SDO 4 E06
resource ADC_BATT 1 C03
resource ADC_RSSI 1 C05
resource ADC_CURR 1 C02
resource PINIO 1 C00
resource FLASH_CS 1 A04
resource OSD_CS 1 B12
resource GYRO_EXTI 1 E01
resource GYRO_CS 1 E04
resource USB_DETECT 1 A08


  • FC Board name and vendor:
  • INAV version string:
    version
    INAV/FLYWOOF745NANO 7.1.0 Mar 27 2024 / 13:03:13 (59a6ee6)
    GCC-10.3.1 20210824 (release)
@b14ckyy
Copy link
Collaborator

b14ckyy commented Apr 8, 2024

@mmosca can you have a look, you changed something around in a7e2911 that includes these 2 outputs as well. Do they have different versions or was that a mistake?

@b14ckyy b14ckyy added the Bugfix label Apr 8, 2024
@cliffkhew
Copy link

Ya,I have the motor 3 not working,waiting for the fix.

@wterreb
Copy link

wterreb commented Apr 29, 2024

Same for me. I am trying to use it on my FLYWOOF745NANO (Flywoo Explorer LR analog) :

Betaflight mapping : << This is working
resource MOTOR 1 B00
resource MOTOR 2 B01
resource MOTOR 3 E09
resource MOTOR 4 E11

But in INAV 5.1: << This is not working
B01: MOTOR1 OUT
C09: MOTOR2 OUT
B00: MOTOR3 OUT
E11: MOTOR4 OUT

So it does not work at all in iNAV. When want to I spin motor 1, then it is motor 2 that spins. And when I try to spin motor 2, then no motor is spinning. Etc etc.

If this was working in INAV, I would have been using INAV long ago. But it feels like every time I try INAV I run into problems like this.

@mmosca
Copy link
Collaborator

mmosca commented Apr 29, 2024

@mmosca can you have a look, you changed something around in a7e2911 that includes these 2 outputs as well. Do they have different versions or was that a mistake?

I think the nano has been broken ever since it was added. I need someone to confirm #9990 works for both the nano and normal one.

They both now match BF config, but I don't own either.

@ramiss
Copy link
Author

ramiss commented Apr 29, 2024

I'm happy to test the nano, if that's helpful.

@wernerterreb
Copy link

wernerterreb commented Apr 30, 2024

@DzikuVx Actually I was playing with this myself last night and managed to get the motor assignment correct. When I go to Outputs and spin the motors now, it is the correct motors that spin for all four. But my pin assignment looks very different to what you committed:

Here is what I used:
This will work on a FlyWoo Explorer LR that has a FLYWOOF745NANO board.

Add this to the file /src/main/target/FLYWOOF745/target.c:

timerHardware_t timerHardware[] = {

DEF_TIM(TIM8, CH2N, PB0, TIM_USE_OUTPUT_AUTO, 0, 0), // M1 , TCH_TMR8_CH2N
DEF_TIM(TIM8, CH3N, PB1, TIM_USE_OUTPUT_AUTO, 0, 0), // M2 , TCH_TMR8_CH3N
DEF_TIM(TIM1, CH1, PE9, TIM_USE_OUTPUT_AUTO, 0, 1), // M3 , TCH_TMR1_CH1DMA2_ST1
DEF_TIM(TIM1, CH2, PE11, TIM_USE_OUTPUT_AUTO, 0, 1), // M4 , TCH_TMR1_CH2

@ramiss
Copy link
Author

ramiss commented Aug 6, 2024

@DzikuVx - This is not resolved. I just installed a fresh 7.1.2 [FLYWOOF745NANO] target on my quad and Motor 2 still isn't responding. Is there any way to get this re-opened and resolved please? How can I help?

@b14ckyy
Copy link
Collaborator

b14ckyy commented Aug 6, 2024

@ramiss Please check the PR for the fix. Its targeted for 8.0 and did not go into 7.1.2
image

You can try a Nightly build of 8.0.

@ramiss
Copy link
Author

ramiss commented Aug 6, 2024

@b14ckyy - Excellent, thanks. I'll try it!

@ramiss
Copy link
Author

ramiss commented Aug 6, 2024

Tested and confirmed fixed in nightly 8.0.0.
Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants