Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match F745 and F745NANO motor pins to BF target #9990

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Apr 29, 2024

INAV was using same motor pins for both variants.

This PR matches motor pins to BF.
Fixes #9899

I don't own this fc, so can't verify the fix.

@mmosca mmosca added this to the 8.0 milestone Apr 29, 2024
@DzikuVx DzikuVx merged commit d74aca7 into master Apr 29, 2024
14 checks passed
mmosca pushed a commit that referenced this pull request Apr 29, 2024
Match F745 and F745NANO motor pins to BF target
@wernerterreb
Copy link

Actually I was playing with this myself last night and managed to get the motor assignment correct. When I go to Outputs and spin the motors now, it is the correct motors that spin for all four. But my pin assignment looks very differnt to what you committed:

Here is what I used:
This will work on a FlyWoo Explorer LR that has a FLYWOOF745NANO board.

Add this to the file /src/main/target/FLYWOOF745/target.c:

timerHardware_t timerHardware[] = {

DEF_TIM(TIM8, CH2N, PB0, TIM_USE_OUTPUT_AUTO, 0, 0), // M1 , TCH_TMR8_CH2N
DEF_TIM(TIM8, CH3N, PB1, TIM_USE_OUTPUT_AUTO, 0, 0), // M2 , TCH_TMR8_CH3N
DEF_TIM(TIM1, CH1, PE9, TIM_USE_OUTPUT_AUTO, 0, 1), // M3 , TCH_TMR1_CH1DMA2_ST1
DEF_TIM(TIM1, CH2, PE11, TIM_USE_OUTPUT_AUTO, 0, 1), // M4 , TCH_TMR1_CH2

@wterreb
Copy link

wterreb commented Apr 30, 2024

Further feedback.. I tested with your settings as well, and your motor mapping is also correct and the correct motors spin as expected.

I will definitely do test flight with this. Thank you very much for this commit.

By the way I am the same user as @wernerterreb above.... just logged in with a different account now.

@mmosca
Copy link
Collaborator Author

mmosca commented Apr 30, 2024

Further feedback.. I tested with your settings as well, and your motor mapping is also correct and the correct motors spin as expected.

I will definitely do test flight with this. Thank you very much for this commit.

By the way I am the same user as @wernerterreb above.... just logged in with a different account now.

If you get all sensors and uarts working, it should fly correctly now as well.

The change was only to the motor outputs and will be included in 7.1.1 once it comes out.

@wernerterreb
Copy link

@mmosca thank you very much. Yeah I still need to sort out the magnetometer, but everything else seems to be working well now. I will be doing some test flying over the weekend.

@wernerterreb
Copy link

And I can confirm now it flies perfectly with these changes.

@wterreb
Copy link

wterreb commented May 3, 2024

@ramiss
Copy link

ramiss commented Aug 6, 2024

I just installed a fresh 7.1.2 stable and Motor 2 is not working just as before? Was this merged into master?

@ramiss
Copy link

ramiss commented Aug 6, 2024

Just learned this is in 8.0 pre-release. thanks all!

@ramiss
Copy link

ramiss commented Aug 6, 2024

Tested and confirmed fixed in nightly 8.0.0.
Thank you all!

JulianTiller pushed a commit to JulianTiller/inav that referenced this pull request Oct 18, 2024
…fixes

Match F745 and F745NANO motor pins to BF target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Target Bug] FlywooF745Nano - Wrong Motor Resource.
5 participants