Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixer tab #10277

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix mixer tab #10277

merged 2 commits into from
Aug 2, 2024

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Aug 2, 2024

Temporarily revert max servos to 18. No need to set it to 34 servos, as we can't output that many yet and it appears to break MSP2_INAV_SERVO_MIXER message.

Blackbox is unaffected for now, as I will try to increase max servo count when using sbus + pwm output on a separate pr and will prune any unused blackbox entries.

@stronnag
Copy link
Collaborator

stronnag commented Aug 2, 2024

blackbox headers ... .... .... ?

@mmosca
Copy link
Collaborator Author

mmosca commented Aug 2, 2024

blackbox headers ... .... .... ?

Will it break if we reduce the number, based on the latest changes? This is mainly so I unbreak the configurator, as I plan to revisit it soon and see if I can fix the msp message and unlock more servos via pwm + sbus + sbus first servo offset.

@mmosca mmosca merged commit ee5d217 into master Aug 2, 2024
22 checks passed
@stronnag
Copy link
Collaborator

stronnag commented Aug 2, 2024

Don't think it will break, just a loose end.

@MrD-RC MrD-RC added this to the 8.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants