Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: gps sensor can not recover from timeout in gps fix estimation mode #9574

Merged

Conversation

RomanLut
Copy link
Contributor

if gps sensor reset for some reason(hw problem?) and got into timeout state, and gps fix estimation mode is enabled, gps sensor is unable to reinitialize because timeout is reset to small value.

@Jetrell
Copy link

Jetrell commented Dec 28, 2023

if gps sensor reset for some reason(hw problem?)

@RomanLut This has been reported with more prevalence, since the 7.0 release.
I've had it happen a few times. But only on one of my builds.
Its using a Walksnail M10, and only occurs at boot up. So it could be HW.

What GPS unit have you experienced it occurring with ?

@RomanLut
Copy link
Contributor Author

RomanLut commented Dec 28, 2023

What GPS unit have you experienced it occurring with ?

Note that this submit fixes a problem where GPS sensor can not be reinitialized after occassional reboot (bad power supply?) while gps fix estimation mode is active (either enabled by GPS OFF logic condition or due to GPS fix loss). It is not related to any problem with GPS sensor where gps fix estimation is not enabled in settings or is not active. Model of sensor is not relevant, it will happend will any sensor because gps fix estimation code prevents reinitialization.

@RomanLut
Copy link
Contributor Author

@DzikuVx Can we have this is the next release? This is fix for edge case in the gpx fix estimation feature.

@sensei-hacker
Copy link
Collaborator

Looks like a straightforward fix.
What could go wrong if it's PR'ed to 8.0?

@MrD-RC MrD-RC modified the milestones: 8.0, 8.1 Nov 25, 2024
@MrD-RC
Copy link
Collaborator

MrD-RC commented Nov 25, 2024

I think it will need to be 8.1. This PR has been pretty silent. It probably should have been merged in to master a long time ago.

The issue is 8.0 is already in RC. This is potentially a simple change. But where this is an edge case. I think having it in master for peer testing would be safer than putting it in to 8.0. Which maybe has 1 or 2 more RC releases before is it stable.

@Jetrell
Copy link

Jetrell commented Nov 25, 2024

@MrD-RC If it can be added to 8.0 RC, it would be very useful for #8347

As @RomanLut said..

Note that this submit fixes a problem where GPS sensor can not be reinitialized after occassional reboot (bad power supply?) while gps fix estimation mode is active (either enabled by GPS OFF logic condition or due to GPS fix loss).

Many times I have tested that feature using the logic condition to disable GNSS sensor fix. I have to land and reboot the FC to get the GNSS unit to communicate again.

@MrD-RC MrD-RC modified the milestones: 8.1, 8.0 Nov 28, 2024
@MrD-RC MrD-RC merged commit b25c1b7 into iNavFlight:master Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants