Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2 bits for msp displayport font page #9942

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

mmosca
Copy link
Collaborator

@mmosca mmosca commented Apr 13, 2024

May allow for future 4 page fonts

@mmosca mmosca added this to the 8.0 milestone Apr 13, 2024
@mmosca
Copy link
Collaborator Author

mmosca commented Apr 13, 2024

I may change the fontPage uint8_t array to attr uint8_t array and combine with the blink flag.

@mmosca mmosca merged commit b7cae2e into master Apr 29, 2024
14 checks passed
@RomanLut
Copy link
Contributor

RomanLut commented May 6, 2024

Blinking attribute handling can be removed from displayport_msp_osd.c completely.

Displayport_msp_osd does not support blinking attibute:

static textAttributes_t supportedTextAttributes(const displayPort_t *displayPort)

Software blinking is used, blinking attibute is not applied to characters in display.c:

static bool displayAttributesRequireEmulation(displayPort_t *instance, textAttributes_t attr)

if (displayAttributesRequireEmulation(instance, attr)) {

TEXT_ATTRIBUTES_REMOVE_BLINK(*attr);

So this code never executes:

and can be removed unless you plan to implement useDeviceBlink option similar to BF.

@MrD-RC
Copy link
Collaborator

MrD-RC commented May 6, 2024

There's no need to remove blink. It is in the API. It should be handled as specified by the API.

@RomanLut
Copy link
Contributor

RomanLut commented May 6, 2024

Should be optional then, displayport_msp_use_device_blink is OFF by default in betaflight, I guess for a reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants