Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly export exrules #519

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Correctly export exrules #519

merged 3 commits into from
Feb 21, 2022

Conversation

pacso
Copy link
Collaborator

@pacso pacso commented Feb 8, 2022

Fixes #518

  • Exports exrules when to_hash is called, regardless of gem version
  • Also fixes to_yaml and to_json since they both call to_hash
  • Removes deprecation warning on use of exrules

@pacso pacso requested a review from seejohnrun February 8, 2022 23:11
@pacso pacso merged commit 2cdfdba into master Feb 21, 2022
@pacso pacso deleted the 518-fix-exrules-to-json branch February 21, 2022 21:38
@anjiemerchant anjiemerchant mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seejohnrun seejohnrun Awaiting requested review from seejohnrun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exrules are not exported to yaml, json or hash
1 participant
@pacso