Split up TypeRefExt::cs_type_string
#3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Jan 30, 2024
|
Looks good, but it fails, so there's a bug somewhere |
|
I forgot an exclamation point... |
bernardnormier
approved these changes
Jan 30, 2024
tools/slicec-cs/src/decoding.rs
Outdated
| @@ -75,7 +73,7 @@ pub fn default_activator(encoding: Encoding) -> &'static str { | |||
| fn decode_member(member: &impl Member, namespace: &str, encoding: Encoding) -> CodeBlock { | |||
| let mut code = CodeBlock::default(); | |||
| let data_type = member.data_type(); | |||
| let type_string = data_type.cs_type_string(namespace, TypeContext::IncomingParam, true); | |||
| let type_string = data_type.incoming_parameter_type_string(namespace, true); | |||
There was a problem hiding this comment.
Should we rename this function "decode_parameter"?
There was a problem hiding this comment.
No, this function is used for both fields and parameters.
But the fact we were passing IncomingParam is actually bogus.
We only use the type_string variable for structs and classes... which don't have a special mapping as parameters.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step towards refactoring our
cs_type_stringfunctions:Currently,
TypeRefExt::cs_type_stringtakes aTypeContext, and has 3 different behaviors depending the type-context.This PR splits this function into 3:
field_type_string,incoming_parameter_type_string, andoutgoing_parameter_type_string.The behavior is identical to before, I've just split each context's match case into a standalone function.
Note that
ParameterExthas it's own function also namedcs_type_string.I will deal with this in my next PR, but wanted to split it up to keep these easy to review.
ParameterExt::cs_type_stringtook abool: ignore_optional, but this was always false, so I removed the parameter and hard-coded false. Otherwise this function was left alone.