Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty property name delegates #2908

Closed
PerikiyoXD opened this issue Feb 22, 2023 · 1 comment · Fixed by #2912
Closed

Empty property name delegates #2908

PerikiyoXD opened this issue Feb 22, 2023 · 1 comment · Fixed by #2912
Labels
Bug Decompiler The decompiler engine itself

Comments

@PerikiyoXD
Copy link

Input code

Having any delegate with stripped names (Using obfuscation methods)

internal delegate int SomeDelegate(string, string);

Let's have a look to the Invoke IL code:

.method public virtual 
	instance int32 Invoke (
		string '',
		string ''
	) runtime managed 
{
}

It uses empty named values, output is wrong.

Erroneous output

internal delegate int SomeDelegate(string, string);

Expected output

internal delegate int SomeDelegate(string P_0, string P_1); 

Details

  • Product in use: ILSpy
  • Version in use: 8.0.0.7246-preview3
@PerikiyoXD PerikiyoXD added Bug Decompiler The decompiler engine itself labels Feb 22, 2023
PerikiyoXD pushed a commit to PerikiyoXD/ILSpy that referenced this issue Feb 22, 2023
@PerikiyoXD
Copy link
Author

I've added a quick fix, it shows proper code on this specific case. I can't provide the binary as it's private and sensitive.

dgrunwald added a commit that referenced this issue Feb 26, 2023
Fix empty parameter names in delegate declarations (fixes #2908)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Decompiler The decompiler engine itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant