Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2013: Add option to extract self-contained executables (PublishSingleFile). #2016

Merged
merged 1 commit into from
May 23, 2020

Conversation

siegfriedpammer
Copy link
Member

This pull request adds the capability to extract self-contained executables to ILSpy.

Currently the user is asked to pick a directory where the files are extracted to. Then these files can be loaded by ILSpy normally.

Alternative suggestion: We could create a new assembly list out of all extracted modules.

@christophwille
Copy link
Member

Suggestion - after detecting that we have an app bundle at our hands, show a simple message dialog first (before folder selection):

Title: ILSpy

You are trying to open a single-file executable (app bundle). In order to work with this type of program, ILSpy will

(i) show you a dialog to select a folder to extract the bundle to
(ii) extract the assemblies (might take a few seconds)
(iii) show you a dialog to select one or more of those extracted assemblies to decompile

Do you want to proceed?

Buttons: Yes / No

The current description in the folder selection dialog isn't a good way of telling the user what is going to happen and especially why. That is the reason there's a No in the interstitial dialog.

@siegfriedpammer siegfriedpammer force-pushed the fix-2013 branch 2 times, most recently from 7130503 to 16ae3fd Compare May 23, 2020 17:22
@siegfriedpammer siegfriedpammer merged commit c96e10a into master May 23, 2020
@siegfriedpammer siegfriedpammer deleted the fix-2013 branch June 7, 2020 07:33
@siegfriedpammer siegfriedpammer restored the fix-2013 branch June 7, 2020 07:33
@siegfriedpammer siegfriedpammer deleted the fix-2013 branch June 7, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants