Refactor searchresult insert

[MikeFH]

Refactoring of the InsertResult method of the SearchPane to use BinarySearch in all cases for sorted insertion, as discussed in #2333
Also contains a small typo fix.

[MikeFH]

I noticed a small problem in the fitness calculation when the search result is a destructor since the method name is always Finalize.
This can lead to a weird sorting of results, for example in a search for "memorystream".

I propose to replace

ILSpy/ILSpy/Search/AbstractEntitySearchStrategy.cs

Line 82 in 97334ef

if (text == ".cctor" || text == ".ctor")

by
if (member.SymbolKind == SymbolKind.Constructor || member.SymbolKind == SymbolKind.Destructor)

Do you think this should be the subject of another issue or another PR or should I include the modification in this PR ?

[siegfriedpammer]

I noticed a small problem in the fitness calculation when the search result is a destructor since the method name is always Finalize.
This can lead to a weird sorting of results, for example in a search for "memorystream".

I propose to replace

ILSpy/ILSpy/Search/AbstractEntitySearchStrategy.cs

Line 82 in 97334ef

if (text == ".cctor" || text == ".ctor")

by
if (member.SymbolKind == SymbolKind.Constructor || member.SymbolKind == SymbolKind.Destructor)
Do you think this should be the subject of another issue or another PR or should I include the modification in this PR ?

Ah, yes, sorry, I just realized you had this question posted... I think, using symbol kind instead of the name is a good idea. If you want, you can provide another PR.

Thank you for your contribution!