Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #665 fixes #2347

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Conversation

tom-englert
Copy link
Contributor

@siegfriedpammer as requested in #2334

@siegfriedpammer
Copy link
Member

Wow... you are really fast! Thanks for fixing this...

I just found another problem:

image

I am unable to find the correct location to change the background color of the tab that the cursor is currently hovering over and also the text color of the explanation looks a bit strange if everything else is black.

Sorry for throwing so many things at you currently. If I were more versed in WPF theming I would fix it myself. Thank you so much!

@tom-englert
Copy link
Contributor Author

@siegfriedpammer no problem, better you find them before they make it into the release 😏

@siegfriedpammer
Copy link
Member

I found another issue: The access keys of the buttons in the "Manage assembly lists..." dialog are no longer working properly... Seems the ContentPresenter is not setting the RecognizesAccessKey property to true somewhere.

@christophwille
Copy link
Member

I found another issue: The access keys of the buttons in the "Manage assembly lists..." dialog are no longer working properly... Seems the ContentPresenter is not setting the RecognizesAccessKey property to true somewhere.

@tom-englert Are you going to add the fix for this to this PR?

@tom-englert
Copy link
Contributor Author

Just pushed...

@siegfriedpammer
Copy link
Member

Thank you for fixing these issues so quickly!

@siegfriedpammer siegfriedpammer merged commit 2fee6f6 into icsharpcode:master Mar 23, 2021
@tom-englert
Copy link
Contributor Author

@siegfriedpammer P.S. thanks for the thorough testing, pointing me to views and features I missed to test - most of them I even didn't know they exist. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants