Allow user to provide ID when generating a PDB #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new parameter to PortablePdbWriter.WritePdb that allows the caller to specify the exact Guid and timestamp that should be used in the generated PDB. This will be useful for several scenarios that are interesting for the Visual Studio debugger's integration: 1. Generating a PDB for an assembly that was built without debug info. The PDB writer currently fails in this case, since the input assembly has no debug directory from which to extract the relevant info. The debugger can provide values that will allow us to load the generated PDB. 2. Generating a PDB for an assembly that has multiple debug directories. The PDB writer currently uses the first debug directory it finds, but this isn't necessarily the correct one. The debugger can provide the correct values.
siegfriedpammer
force-pushed
the
custom-pdb-id
branch
from
dd2bdb6 to
071ca33
Compare
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Visual Studio debugger's decompiler integration needs to be able to control the ID used for generated PDBs. There are a couple of scenarios that are interesting to us:
Solution
This commit adds a new parameter to
PortablePdbWriter.WritePdbthat allows the caller to specify the exact Guid and timestamp that should be used in the generated PDB.