Change theme selection UI #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2929
Problem
The theme selector combobox in the toolbar seems out of place.
Solution
Any comments on the approach taken, its consistency with surrounding code, etc.
This replaces the theme selector in the toolbar with a menu item and a setting in the options:
Which part of this PR is most in need of attention/improvement?
The theme is currently saved in the
SessionSettings, and this PR doesn't change that. But this leads to updating theSessionSettingsfrom theDisplaySettingspanel.An alternative would be to move the theme to
DisplaySettings, but that would require updating it when switching the theme from the main menu and saving it on exit just like theSessionSettings, so I'm not sure if that would be better in the end.