Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define Docker image #1

Merged
merged 6 commits into from
Apr 3, 2024
Merged

feat: Define Docker image #1

merged 6 commits into from
Apr 3, 2024

Conversation

microamp
Copy link
Contributor

@microamp microamp commented Mar 28, 2024

Creating a new image for Trustee as per @NGPixel's suggestion earlier.

I think it would be preferrable to create a docker image that inherits the legacy-base one and adds the apache config change, as it's not private data and it makes 1 less manual thing to take care of should a redeploy be needed (and it avoids mounting a volume just for 1 config file).

(Update: The repo has been renamed.)

I noticed that /etc/apache2/sites-enabled/000-default.conf is just a symlink of /etc/apache2/sites-available/000-default.conf, so I'm updating the actual file rather than the symlink here.

The repo is currently private but can be mad public once this PR is merged. (The repo will remain private for now. See comments below.) Feel free to make any necessary changes.

@microamp microamp changed the title feat: Publish Docker image feat: Define Docker image Mar 28, 2024
@microamp microamp requested review from kesara and NGPixel March 28, 2024 10:42
@rjsparks
Copy link
Member

It should not be made public with this name. The trustees doesn't consider themselves, or their website legacy, and it would attract an unnecessary discussion with the trust explaining its purpose. I suggest something like 'trustee-proxyenv'

@rjsparks
Copy link
Member

Also remember when naming anything that might become public (and note that it's hard to guess what might) to follow the guidance at https://datatracker.ietf.org/doc/statement-iesg-iesg-statement-on-inclusive-language-20210511/

@microamp
Copy link
Contributor Author

microamp commented Apr 1, 2024

@rjsparks Thanks for your comments. Understood. I have renamed the repo, and replaced all occurrences of the old name with the new one.

Update: I'll make the repo public based on the conversation I had with the team earlier.

@microamp microamp merged commit 33eb772 into main Apr 3, 2024
1 check passed
@microamp microamp deleted the feat/build-docker-image branch April 3, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants