Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes titles excess spaces on posts and pages. #1609

Merged
merged 7 commits into from
Apr 21, 2017
Merged

Fixes titles excess spaces on posts and pages. #1609

merged 7 commits into from
Apr 21, 2017

Conversation

ivan-nginx
Copy link
Collaborator

@ivan-nginx ivan-nginx commented Apr 20, 2017

Before that:
image
After that:
image

Addition to #1522

Note: i understand what afterthat fix block code is hard for edit, but spaces in Titles is no good for seo and they not may minified like other scripts, etc.
@ivan-nginx ivan-nginx changed the title Fixes titles excess spaces on posts and pages. Addition to #1522 Fixes titles excess spaces on posts and pages. Apr 20, 2017
{{ page.title + page_title_suffix }}
{% endif %}
{% endblock %}
{% block title %}{% set page_title_suffix = ' | ' + config.title %}{% if page.type === "categories" and not page.title %}{{ __('title.category') + page_title_suffix }}{% elif page.type === "tags" and not page.title %}{{ __('title.tag') + page_title_suffix }}{% else %}{{ page.title + page_title_suffix }}{% endif %}{% endblock %}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard for human to read.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But easy to read for search engines. For them it's will /n/r &nbsp in Titles. It's very bad.
I wrote about it in subcomment.

@ivan-nginx ivan-nginx merged commit 836a4bf into iissnan:master Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants