Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json search engine support #1635

Merged
merged 2 commits into from
Apr 29, 2017
Merged

json search engine support #1635

merged 2 commits into from
Apr 29, 2017

Conversation

flashlab
Copy link
Contributor

@flashlab flashlab commented Apr 28, 2017

add json option to local search.

TODO:

  • search with tag and catalog
  • doc update

@ivan-nginx
Copy link
Collaborator

@flashlab can u please give some comments and examples how to use it?

@flashlab
Copy link
Contributor Author

flashlab commented Apr 28, 2017

In the local search field of config file, 'search.xml' will end with xml database generated while 'search.json' comes with the json. For xml will raise out encoding error for some circonstances. @ivan-nginx

@ivan-nginx
Copy link
Collaborator

@flashlab and? How to use json in search? Need something like documentation to test it for merge.

@flashlab
Copy link
Contributor Author

Update generator plugin to the latest version. @ivan-nginx

@ivan-nginx
Copy link
Collaborator

@flashlab there are 2 generators for search: hexo-generator-search and hexo-generator-searchdb. Both support json?

@flashlab
Copy link
Contributor Author

yes. but only the latter one is compatible with Next.

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Apr 28, 2017

@flashlab need to update hexo-generator-search to latest version, which is automatically support json objects, right?

but only the latter one is compatible with Next

So, hexo-generator-searchdb for now is not compatible with Next, right?

@flashlab
Copy link
Contributor Author

flashlab commented Apr 28, 2017

No, I mean hexo-genrator-searchdb is compatible. the latest vesion(1.0.5) support json. Check out the plugin readme pleaase.

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Apr 29, 2017

@flashlab ok, lets repeat it:

  1. This pull is support compatible with json objects for Next theme.
  2. To use this json compatible, need to setup hexo-generator-search-db instead of original hexo-generator-search.
  3. In _config.yml add:
search:
  path: search.json

It is right?


P.S. Also, can u, please, rename path from
https://github.com/flashlab/hexo-generator-search to
https://github.com/flashlab/hexo-generator-searchdb
to see in google what it's modification and not just original fork?

@flashlab
Copy link
Contributor Author

@ivan-nginx it's forked because it was modified from the original one to work better with Next. No need to initiate a new path I think.

@ivan-nginx
Copy link
Collaborator

@flashlab ok, what about last question?

It is right?

@flashlab
Copy link
Contributor Author

flashlab commented Apr 29, 2017

Absolutely right. And we may continue this conversation in gitter;)

@ivan-nginx ivan-nginx merged commit becbd50 into iissnan:master Apr 29, 2017
@ivan-nginx
Copy link
Collaborator

And we may continue this conversation in gitter

Ok, check gitter, there is 1 bug.

@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Apr 30, 2017

There is some instructions for use hexo-generator-search-db with this pull request. Check your NodeJS and NPM versions.

@ivan-nginx ivan-nginx removed the Bug label Apr 30, 2017
@flashlab flashlab deleted the patch branch June 14, 2017 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants