Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Footer in Gemini and Pisces always keep in bottom. #1824

Closed
wants to merge 4 commits into from
Closed

FIX: Footer in Gemini and Pisces always keep in bottom. #1824

wants to merge 4 commits into from

Conversation

AlynxZhou
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue Number(s): #1818

What is the new behavior?

Footer in Gemini and Pisces always keep in bottom.

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx ivan-nginx added this to the v5.1.3 milestone Aug 23, 2017
@ivan-nginx
Copy link
Collaborator

ivan-nginx commented Aug 24, 2017

Can u show here Github pages code? Your code in footer.swig and CSS if exists.

@AlynxZhou
Copy link
Contributor Author

Hosted by <a href="https://pages.github.com" style="font-weight: bold">GitHub Pages</a>
<br>
Hosted by <a href="https://pages.coding.me" style="font-weight: bold">Coding Pages</a>

@ivan-nginx In China we have a github-like website called coding, some people like me use it as a mirror in China, but it ask user to add those lines "Hosted by Coding Pages" in pages, I added them in footer, and then I need to enlarge the footer height to contain them properly. However I think this has no influence to NexT, not all people need this.

@ivan-nginx ivan-nginx closed this Sep 15, 2017
@ivan-nginx ivan-nginx removed this from the v5.1.3 milestone Sep 15, 2017
@ivan-nginx
Copy link
Collaborator

@AlynxZhou there is new option custom_text in #1886.

@AlynxZhou
Copy link
Contributor Author

@ivan-nginx That's really cool! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants