Fix canvas-ribbon error. #1932
Merged
Fix canvas-ribbon error. #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 11, 2017
| canvasRibbon.width = width * dpr; // 返回实际宽高 | ||
| canvasRibbon.height = height * dpr; | ||
| ctx.scale(dpr, dpr); // 水平、竖直方向缩放 | ||
| ctx.globalAlpha = config.alpha; // 图形透明度 |
|
|
||
| // 获取自定义配置 | ||
| var ribbon = document.getElementById('ribbon'); // 当前加载的script | ||
| config = { |
| ctx.fillStyle = '#' + (cos(r) * 127 + 128 << 16 | cos(r + PI_2 / 3) * 127 + 128 << 8 | cos(r + PI_2 / 3 * 2) * 127 + 128).toString(16); | ||
| ctx.fill(); // 根据当前样式填充路径 | ||
| path[0] = path[1]; // 起点更新为当前终点 | ||
| path[1] = {x: nextX, y: nextY} // 更新终点 |
|
|
||
| r -= PI_2 / -50; | ||
| // 随机生成并设置canvas路径16进制颜色 | ||
| ctx.fillStyle = '#' + (cos(r) * 127 + 128 << 16 | cos(r + PI_2 / 3) * 127 + 128 << 8 | cos(r + PI_2 / 3 * 2) * 127 + 128).toString(16); |
There was a problem hiding this comment.
Line is too long.
Unexpected use of '<<'.
Unexpected use of '|'.
| path = [{x: 0, y: height * 0.7 + RIBBON_WIDTH}, {x: 0, y: height * 0.7 - RIBBON_WIDTH}]; | ||
| // 路径没有填满屏幕宽度时，绘制路径 | ||
| while (path[1].x < width + RIBBON_WIDTH) { | ||
| draw(path[0], path[1]) |
| var ribbon = document.getElementById('ribbon'); // 当前加载的script | ||
| config = { | ||
| zIndex: getAttr(ribbon, "zIndex", -1), // z-index | ||
| alpha: getAttr(ribbon, "alpha", 0.6), // alpha |
| // 获取自定义配置 | ||
| var ribbon = document.getElementById('ribbon'); // 当前加载的script | ||
| config = { | ||
| zIndex: getAttr(ribbon, "zIndex", -1), // z-index |
| } | ||
|
|
||
| function getAttr(script, attr, default_val) { | ||
| return Number(script.getAttribute(attr)) || default_val; |
There was a problem hiding this comment.
Identifier 'default_val' is not in camel case.
| targetA = false | ||
| } | ||
|
|
||
| function getAttr(script, attr, default_val) { |
There was a problem hiding this comment.
Identifier 'default_val' is not in camel case.
| targetA = true; | ||
| !function () { | ||
| document.addEventListener('touchmove', function (e) { | ||
| e.preventDefault() |
|
Thanks! |
|
@geekrainy but i see bug in your blog: https://rainylog.com/tags/ — sidebar get wrong position. It is normal to have so many errors in this script? |
|
@ivan-nginx I have noticed this problem, it is not caused by this script. This is my own branch of the problem, I will fix it. |
|
@geekrainy ok, it's somewhere in scripts with sidebar alignment. See |
3 tasks
|
@geekrainy can u comment #1935 issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If use plugin hexo-all-minifier, will report an error:
So I upgrade this script file from https://github.com/zproo/canvas-ribbon.
Issue Number(s): N/A
What is the new behavior?
Now error is not appear.
Does this PR introduce a breaking change?