Skip to content

Commit f5951fb

Browse files
authored
feat: Remove Ubuntu 23.10 package build (Issue: #138) (MR #143)
1 parent d7c8373 commit f5951fb

File tree

2 files changed

+11
-24
lines changed

2 files changed

+11
-24
lines changed

.github/workflows/release-jobs.yml

+11-10
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,17 @@ jobs:
9393
upload_url: ${{ env.SAMBA_EXPORTER_UPLOAD_URL }}
9494
asset_path: ./bin/deb-packages/binary/samba-exporter_${{ env.SAMBA_EXPORTER_RELEASE_TAG }}~ppa1~ubuntu24.04_amd64.deb
9595
asset_name: samba-exporter_${{ env.SAMBA_EXPORTER_RELEASE_TAG }}~ppa1~ubuntu24.04_amd64.deb
96-
asset_content_type: application/zip
97-
- name: Upload Release Asset for Ubuntu 23.10
98-
uses: actions/upload-release-asset@v1
99-
env:
100-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
101-
with:
102-
upload_url: ${{ env.SAMBA_EXPORTER_UPLOAD_URL }}
103-
asset_path: ./bin/deb-packages/binary/samba-exporter_${{ env.SAMBA_EXPORTER_RELEASE_TAG }}~ppa1~ubuntu23.10_amd64.deb
104-
asset_name: samba-exporter_${{ env.SAMBA_EXPORTER_RELEASE_TAG }}~ppa1~ubuntu23.10_amd64.deb
105-
asset_content_type: application/zip
96+
asset_content_type: application/zip
97+
# This section will be used for Ubuntu 24.10 packages
98+
# - name: Upload Release Asset for Ubuntu 23.10
99+
# uses: actions/upload-release-asset@v1
100+
# env:
101+
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
102+
# with:
103+
# upload_url: ${{ env.SAMBA_EXPORTER_UPLOAD_URL }}
104+
# asset_path: ./bin/deb-packages/binary/samba-exporter_${{ env.SAMBA_EXPORTER_RELEASE_TAG }}~ppa1~ubuntu23.10_amd64.deb
105+
# asset_name: samba-exporter_${{ env.SAMBA_EXPORTER_RELEASE_TAG }}~ppa1~ubuntu23.10_amd64.deb
106+
# asset_content_type: application/zip
106107
- name: Upload Release Asset for Debian 12
107108
uses: actions/upload-release-asset@v1
108109
env:

build/PublishLaunchpadInDocker.sh

-14
Original file line numberDiff line numberDiff line change
@@ -203,20 +203,6 @@ echo "Delete the container image when done"
203203
docker rmi -f $(docker images --filter=reference="launchapd-publish*" -q)
204204
docker builder prune --all --force
205205

206-
if [ "$dockerError" == "false" ];then
207-
echo "Publish tag $tag on launchpad within a docker cotainer for mantic"
208-
echo "# ###################################################################"
209-
buildAndRunDocker "mantic"
210-
if [ "$?" != "0" ]; then
211-
dockerError="true"
212-
echo "Error while publish package for mantic"
213-
fi
214-
fi
215-
echo "# ###################################################################"
216-
echo "Delete the container image when done"
217-
docker rmi -f $(docker images --filter=reference="launchapd-publish*" -q)
218-
docker builder prune --all --force
219-
220206
if [ "$dockerError" == "false" ];then
221207
echo "Publish tag $tag on launchpad within a docker cotainer for noble"
222208
echo "# ###################################################################"

0 commit comments

Comments
 (0)