Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped to version 1.2.0 #31

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Bumped to version 1.2.0 #31

merged 1 commit into from
Feb 6, 2023

Conversation

caldwellb
Copy link
Member

No description provided.

@caldwellb caldwellb requested a review from adrianleh January 30, 2023 16:19
Copy link
Member

@adrianleh adrianleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. However, having the .opam file which is generated from the dune project looks like tech debt to me

@k4rtik
Copy link
Member

k4rtik commented Jan 30, 2023

having the .opam file which is generated from the dune project looks like tech debt to me

I believe I had to include it because the CI required it, see https://github.com/coq-community/docker-coq-action/blob/master/README.md#opam If there is a way to autogenerate it during the CI run, it will certainly be nice.

@adrianleh
Copy link
Member

@caldwellb is currently working on fixing that. We filed an issue and got a response on how to hopefully make that work

@k4rtik
Copy link
Member

k4rtik commented Jan 31, 2023

I see coq-community/docker-coq-action#83 is what you are referring to. I find it helpful to cross-link for context.

@caldwellb caldwellb merged commit 9585279 into main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants