fix numpy scalar hash for bigendian #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
force-pushed
the
fix-numpy-repr
branch
2 times, most recently
from
99dc1b9 to
4ab016c
Compare
matthiasdiener
force-pushed
the
fix-numpy-repr
branch
from
4ab016c to
dbe4e5f
Compare
matthiasdiener
changed the title
Co-authored-by: Michał Górny <[email protected]>
inducer
reviewed
Jan 17, 2025
pytools/persistent_dict.py
Outdated
| @@ -68,6 +68,9 @@ class RecommendedHashNotFoundWarning(UserWarning): | |||
| _HAS_ATTRS = True | |||
|
|
|||
|
|
|||
| IS_BIGENDIAN = sys.byteorder == "big" | |||
There was a problem hiding this comment.
Suggested change
| IS_BIGENDIAN = sys.byteorder == "big" | |
| _IS_BIGENDIAN = sys.byteorder == "big" |
There was a problem hiding this comment.
Done in 49820c7
pytools/persistent_dict.py
Outdated
| @@ -68,6 +68,9 @@ class RecommendedHashNotFoundWarning(UserWarning): | |||
| _HAS_ATTRS = True | |||
|
|
|||
|
|
|||
| IS_BIGENDIAN = sys.byteorder == "big" | |||
There was a problem hiding this comment.
Add a comment that this is here so it can be changed by mock testing.
There was a problem hiding this comment.
Done in 0194fc6
inducer
reviewed
Jan 17, 2025
|
Thanks a lot, to you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262. Followup of #259, #260, #261.
Reverts #260.
Closes #261.
TODO:
Please squash