Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tendermint 0.23.4 #1762

Merged
merged 6 commits into from
Jan 13, 2022
Merged

Update to tendermint 0.23.4 #1762

merged 6 commits into from
Jan 13, 2022

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Jan 13, 2022 •
edited by romac
Loading

Closes: #1641
Unblocks: #1631

Description

The latest release of tendermint-rs includes informalsystems/tendermint-rs#1069 which fixes #1641

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@mzabaluev mzabaluev added the I: dependencies Internal: related to dependencies label Jan 13, 2022
@mzabaluev mzabaluev requested review from romac and adizere January 13, 2022 09:57
@mzabaluev mzabaluev requested a review from ancazamfir as a code owner January 13, 2022 09:57
@mzabaluev
guide: Remove OpenSSL pre-requisite
b94eabe 
The build no longer requires this.
romac
romac reviewed Jan 13, 2022
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see so many deduplicated package versions and removals :)

romac
romac requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs a changelog entry and then we can merge.

@romac romac merged commit f78642a into master Jan 13, 2022
@romac romac deleted the mikhail/tendermint-without-openssl branch January 13, 2022 14:32
@mzabaluev mzabaluev mentioned this pull request Jan 13, 2022
Merged
6 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@mzabaluev @romac
Update to tendermint 0.23.4 and harmonize the dependencies to use a s…
6721c90 
…ingle TLS stack (informalsystems#1762)

* Remove the extra patch section in Cargo.toml

* Update tendermint-rs to 0.23.4

* guide: Remove OpenSSL pre-requisite

The build no longer requires this.

* Add changelog entry

* Update changelog entry

Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
I: dependencies Internal: related to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize the dependencies to use a single TLS stack
2 participants
@mzabaluev @romac