Remove clock feature (#341)

* Remove `clock` feature

* Tests can link with std

* clippy config

* add issue link

* Fix clippy uninlined_format_args catch

Co-authored-by: Farhad Shabani <[email protected]>

Author: plafer

.github/workflows/rust.yml

@@ -85,7 +85,7 @@ jobs:
       - uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-          args: --no-default-features --features "clock" --all-targets # tests need the clock feature
+          args: --no-default-features --lib
 
   test-stable:
     runs-on: ubuntu-latest

crates/ibc/Cargo.toml

@@ -33,10 +33,9 @@ std = [
     "num-traits/std",
     "uint/std",
     "primitive-types/std",
-    "clock",
+    "tendermint/clock",
     "tendermint/std",
 ]
-clock = ["tendermint/clock", "time/std"]
 parity-scale-codec = ["dep:parity-scale-codec", "dep:scale-info"]
 borsh = ["dep:borsh"]
 
@@ -45,7 +44,7 @@ val_exec_ctx = []
 
 # This feature grants access to development-time mocking libraries, such as `MockContext` or `MockHeader`.
 # Depends on the `testgen` suite for generating Tendermint light blocks.
-mocks = ["tendermint-testgen", "clock", "cfg-if", "parking_lot"]
+mocks = ["tendermint-testgen", "tendermint/clock", "cfg-if", "parking_lot"]
 mocks-no-std = ["cfg-if"]
 
 [dependencies]
@@ -101,4 +100,4 @@ test-log = { version = "0.2.10", features = ["trace"] }
 tendermint-rpc = { version = "0.28", features = ["http-client", "websocket-client"] }
 tendermint-testgen = { version = "0.28" } # Needed for generating (synthetic) light blocks.
 parking_lot = { version = "0.12.1" }
-cfg-if = { version = "1.0.0" }
+cfg-if = { version = "1.0.0" }

crates/ibc/src/core/ics02_client/handler/create_client.rs

@@ -122,8 +122,7 @@ where
     )));
 
     ctx.log_message(format!(
-        "success: generated new client identifier: {}",
-        client_id
+        "success: generated new client identifier: {client_id}"
     ));
 
     Ok(())

crates/ibc/src/core/ics03_connection/handler/conn_open_init.rs

@@ -69,8 +69,7 @@ where
     let conn_id_on_a = ConnectionId::new(ctx_a.connection_counter()?);
 
     ctx_a.log_message(format!(
-        "success: conn_open_init: generated new connection identifier: {}",
-        conn_id_on_a
+        "success: conn_open_init: generated new connection identifier: {conn_id_on_a}"
     ));
 
     {

crates/ibc/src/lib.rs

@@ -11,6 +11,8 @@
     rust_2018_idioms
 )]
 #![forbid(unsafe_code)]
+// https://github.com/cosmos/ibc-rs/issues/342
+#![allow(clippy::result_large_err)]
 #![doc(html_root_url = "https://docs.rs/ibc/0.25.0")]
 //! This library implements the InterBlockchain Communication (IBC) protocol in Rust. IBC is
 //! a distributed protocol that enables communication between distinct sovereign blockchains.

crates/ibc/src/timestamp.rs

@@ -139,7 +139,7 @@ impl Timestamp {
     }
 
     /// Returns a `Timestamp` representation of the current time.
-    #[cfg(feature = "clock")]
+    #[cfg(feature = "std")]
     pub fn now() -> Timestamp {
         Time::now().into()
     }