Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove clock feature #341

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Remove clock feature #341

merged 5 commits into from
Jan 10, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jan 10, 2023

Closes: #340

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Base: 63.80% // Head: 63.81% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (431c144) compared to base (5d2ca20).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   63.80%   63.81%           
=======================================
  Files         124      124           
  Lines       13776    13774    -2     
=======================================
  Hits         8790     8790           
+ Misses       4986     4984    -2
Impacted Files Coverage Δ
...ibc/src/core/ics02_client/handler/create_client.rs 35.18% <0.00%> (+0.32%) ⬆️
...rc/core/ics03_connection/handler/conn_open_init.rs 56.31% <0.00%> (+0.54%) ⬆️
crates/ibc/src/lib.rs 100.00% <ø> (ø)
crates/ibc/src/timestamp.rs 48.87% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plafer plafer marked this pull request as ready for review January 10, 2023 15:05
@plafer plafer requested a review from Farhad-Shabani January 10, 2023 15:05
@plafer plafer mentioned this pull request Jan 10, 2023
Open
Farhad-Shabani
Farhad-Shabani approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Farhad-Shabani Farhad-Shabani merged commit b3f921c into main Jan 10, 2023
@Farhad-Shabani Farhad-Shabani deleted the plafer/340-remove-clock branch January 10, 2023 17:38
@plafer plafer mentioned this pull request Jan 12, 2023
Merged
7 tasks
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
@plafer @Farhad-Shabani
Remove clock feature (#341)
75a7267 
* Remove `clock` feature

* Tests can link with std

* clippy config

* add issue link

* Fix clippy uninlined_format_args catch

Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farhad-Shabani Farhad-Shabani Farhad-Shabani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the clock feature
2 participants
@plafer @Farhad-Shabani