Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dispatch() and decode() pub again #343

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jan 10, 2023

Makes dispatch() and decode() pub again since we're not yet ready to make our domain Msg types private (#324).

Reverts these changes which were recently made in #328.

@plafer plafer requested a review from Farhad-Shabani January 10, 2023 19:43
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 63.81% // Head: 63.80% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (e35b9ef) compared to base (b3f921c).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   63.81%   63.80%   -0.01%     
==========================================
  Files         124      124              
  Lines       13774    13771       -3     
==========================================
- Hits         8790     8787       -3     
  Misses       4984     4984              
Impacted Files Coverage Δ
crates/ibc/src/core/ics26_routing/handler.rs 91.11% <50.00%> (-0.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Farhad-Shabani Farhad-Shabani merged commit 59dd3d9 into main Jan 10, 2023
@Farhad-Shabani Farhad-Shabani deleted the plafer/fix-api branch January 10, 2023 19:58
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants