Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: remove usage of deprecated method in client #166

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Mar 4, 2020

One-liner that fixes the build again.

I've verified that this change doesn't modify the current logic/init. See https://github.com/hyperium/hyper/pull/2142/files for yourself in case you have doubts.

ref https://circleci.com/gh/interchainio/tendermint-rs/1202
closes #165

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

- obsolete in this context
@codecov-io
Copy link

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   39.68%   39.68%           
=======================================
  Files          91       91           
  Lines        3276     3276           
  Branches      490      490           
=======================================
  Hits         1300     1300           
  Misses       1690     1690           
  Partials      286      286
Impacted Files Coverage Δ
tendermint/src/rpc/client.rs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5b51f4...6bfff22. Read the comment docs.

@liamsi liamsi requested review from Shivani912 and xla March 4, 2020 16:43
@brapse
Copy link
Contributor

brapse commented Mar 5, 2020

LGTM 👍

@liamsi
Copy link
Member Author

liamsi commented Mar 5, 2020

Thanks, can you approve @brapse? Otherwise I can't merge.

@greg-szabo greg-szabo requested a review from brapse March 5, 2020 14:13
@brapse brapse merged commit 6df2a92 into master Mar 5, 2020
@xla xla deleted the ismail/remove_deprecated branch March 5, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build broken after recent hyper upgrade
4 participants