abci: ADR-008 Merge abci-rs into tendermint-rs
#510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xla
changed the title
abci-rs into tendermint-rsabci-rs into tendermint-rs
xla
previously approved these changes
Aug 11, 2020
Closed
Co-authored-by: Alexander Simmerl <[email protected]>
Co-authored-by: Alexander Simmerl <[email protected]>
Co-authored-by: Alexander Simmerl <[email protected]>
Co-authored-by: Alexander Simmerl <[email protected]>
ebuchman
reviewed
Sep 20, 2020
|
|
||
| ### Negative/Neutral | ||
|
|
||
| - Developer is forced to use `async` Rust. |
There was a problem hiding this comment.
I really like what is described in (1) here and seems to be a possible convergence point amidst all the discussion to work towards, and something that is done in other rust crates, where the core is implemented synchronously and an async wrapper is provided. The extra maintenance cost for the wrapper seems minimal compared to the user/flexibility benefit, especially if the synchronous core is simple enough.
Would it make sense for abci2 to be used as such a core and adapt abci-rs to be an async wrapper around it, and expose both ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered