Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --commit option to git subrepo pull command #620

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

giladsh1
Copy link

No description provided.

@admorgan
Copy link
Collaborator

I don't see how this is better than using git subrepo pull --branch <sha> which already works.

Copy link
Collaborator

@admorgan admorgan Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help-function.bash is a generated file. These changes need to be made at the source of that generation. Use 'make update` to force the generation of these files.

Copy link
Collaborator

@admorgan admorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also like to know why you feel this is better than the solution that already works of using --branch <SHA> to do the same thing. If you would like to keep this option it should also mention somewhere that git subrepo pull is effected by this option.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git subrepo pull --commit would override any --branch option. There isn't any comments to the user or the application indicting this is by design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants