Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require makara in makara abstract adapter #54

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Conversation

sax
Copy link
Contributor

@sax sax commented Jul 24, 2014

When using rails 4.1.2 release candidates, servers are unable to start because of
an error,

uninitialized constant Makara
from /path/to/bundle/ruby/2.1.0/bundler/gems/makara-59b01c0ecfec/lib/active_record/connection_adapters/makara_abstract_adapter.rb:4:in `<module:ActiveRecord>'
from /path/to/bundle/ruby/2.1.0/bundler/gems/makara-59b01c0ecfec/lib/active_record/connection_adapters/makara_abstract_adapter.rb:3:in `<top (required)>'
from /path/to/bundle/ruby/2.1.0/bundler/gems/makara-59b01c0ecfec/lib/active_record/connection_adapters/makara_postgresql_adapter.rb:1:in `<top (required)>'

I think that ActiveRecord must be requiring files in some slightly different order
than expected.

When using rails 4.1.2 release candidates, servers are unable to start because of
an error,

```
uninitialized constant Makara
from /path/to/bundle/ruby/2.1.0/bundler/gems/makara-59b01c0ecfec/lib/active_record/connection_adapters/makara_abstract_adapter.rb:4:in `<module:ActiveRecord>'
from /path/to/bundle/ruby/2.1.0/bundler/gems/makara-59b01c0ecfec/lib/active_record/connection_adapters/makara_abstract_adapter.rb:3:in `<top (required)>'
from /path/to/bundle/ruby/2.1.0/bundler/gems/makara-59b01c0ecfec/lib/active_record/connection_adapters/makara_postgresql_adapter.rb:1:in `<top (required)>'
```

I think that ActiveRecord must be requiring files in some slightly different order
than expected.
@sax
Copy link
Contributor Author

sax commented Jul 24, 2014

Nope. This was something we were doing with bundler in the effected application. This shouldn't actually be necessary.

@sax sax closed this Jul 24, 2014
@neonishu
Copy link

@sax , Can you shed some light on the something we were doing with bundler, I am facing the same issue. I have an application serving APIs with Grape. And, this is the exact same issue that I faced. ActiveRecord version is activerecord (4.2.7.1) Appreciate a response here.

@sax
Copy link
Contributor Author

sax commented Oct 17, 2018

I wish I could help. This is so long ago, and I no longer work at / have access to the relevant repositories to look at git history.

@neonishu
Copy link

cc/ @bleonard
I am using Grape with Activerecord v 4.x. I am facing same issue, can we merge this pr/change ?
I tried using Makara version 0.4.0/0.3.10/0.3.9 but faced same issue with all of them.

@bleonard bleonard reopened this Nov 19, 2018
@bleonard
Copy link
Contributor

Seems fine to me.

@bleonard bleonard merged commit a506055 into instacart:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants