-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Experimental NPM workspaces (move away from lerna in v2) #421
Conversation
749041a
to
b8d4d8c
Compare
0392051
to
ee87667
Compare
8560488
to
62fd318
Compare
refs 80779 - removed package lock files - more coming soon
62fd318
to
32722fd
Compare
[ci skip]
I'd right now not continue with playing with this. I'd suggest to touch this area again when NPM workspaces has less problems (see PR description). On top of the two "blockers" some tests where failing in shared-metrics package, because the way NPM workspaces installs dependencies doesn't make the package happy. We rely a lot on the fact that dependencies are physically available in I am still convinced that the switch will be great. Happy to switch over as soon as we can. But for know I'd stick with lerna. |
NPM workspaces are so simple ❤️
These are my first findings (they might be not 100% correct, but will be corrected if needed):
npm i
-> will just install all dependencies in root + workspaces)npm uninstall mocha --workspaces
(this has not worked with lerna, it was a hard)Downside: Does not work well with lerna, because it's just too different. But you can still use lerna commands such as lerna version or lerna publish as far as I can see. Which is the most important fact.
This needs more brain and testing, but the first impression is really good!
lerna version --no-git-tag-version --no-push
test itlerna publish
test itNPM workspaces limitations