Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add democracy pallet governance + fix benchmark script #118

Merged
merged 18 commits into from
May 13, 2022

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented May 2, 2022

  • adds pallet democracy

  • adds a council

  • adds a technical committee

  • updates the benchmark script (fix + no need to list the pallet separately any more)

  • test runtime upgrade

  • test runtime upgrade via democracy pallet

  • benchmark pallet collective & democracy

closes #109

@haerdib haerdib self-assigned this May 2, 2022
@haerdib haerdib force-pushed the bh-democracy-pallet branch from 4ed8b56 to a057782 Compare May 6, 2022 08:58
@haerdib haerdib marked this pull request as ready for review May 9, 2022 12:20
@haerdib haerdib requested review from brenzi and clangenb May 9, 2022 12:22
@haerdib haerdib changed the title Add democracy pallet governance Add governance May 9, 2022
@haerdib haerdib changed the title Add governance Add democracy pallet governance May 9, 2022
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, but I am happy that we achieve that with such a few lines of code!

type Scheduler = Scheduler;
type PalletsOrigin = OriginCaller;
type MaxVotes = MaxVotes;
type WeightInfo = pallet_democracy::weights::SubstrateWeight<Runtime>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above for the substrate weights.

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, cool!

@haerdib haerdib mentioned this pull request May 11, 2022
2 tasks
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haerdib haerdib changed the title Add democracy pallet governance Add democracy pallet governance + fix benchmark script May 11, 2022
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@brenzi brenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit reflecting my take on origin thresholds

please review before merging @haerdib

Copy link
Contributor Author

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks for the input!

@haerdib
Copy link
Contributor Author

haerdib commented May 13, 2022

Should be ready to test on Rococo, IMO.

@brenzi brenzi merged commit db6d343 into master May 13, 2022
@haerdib haerdib deleted the bh-democracy-pallet branch May 13, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Sudo on Rococo Local
3 participants