-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add democracy pallet governance + fix benchmark script #118
Conversation
4ed8b56
to
a057782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions, but I am happy that we achieve that with such a few lines of code!
type Scheduler = Scheduler; | ||
type PalletsOrigin = OriginCaller; | ||
type MaxVotes = MaxVotes; | ||
type WeightInfo = pallet_democracy::weights::SubstrateWeight<Runtime>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above for the substrate weights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit reflecting my take on origin thresholds
please review before merging @haerdib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Thanks for the input!
Should be ready to test on Rococo, IMO. |
adds pallet democracy
adds a council
adds a technical committee
updates the benchmark script (fix + no need to list the pallet separately any more)
test runtime upgrade
test runtime upgrade via democracy pallet
benchmark pallet collective & democracy
closes #109