[SYCL][RTC] Hide user-facing RTC kernel ids #17356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopperm
reviewed
Mar 9, 2025
| @@ -775,6 +775,11 @@ class kernel_bundle_impl { | |||
| const std::vector<device> &get_devices() const noexcept { return MDevices; } | |||
|
|
|||
| std::vector<kernel_id> get_kernel_ids() const { | |||
| // RTC kernel bundles shouldn't have user-facing kernel ids, return an | |||
| // empty vector when the bundles contains RTC kernels. | |||
| if (MLanguage == ext::oneapi::experimental::source_language::sycl_jit) { | |||
There was a problem hiding this comment.
Suggested change
| if (MLanguage == ext::oneapi::experimental::source_language::sycl_jit) { | |
| if (MLanguage == syclex::source_language::sycl_jit) { |
| // for '$' should be enough. | ||
| ids.erase(std::remove_if(ids.begin(), ids.end(), | ||
| [](kernel_id id) { | ||
| return strchr(id.get_name(), '$') != nullptr; |
There was a problem hiding this comment.
Nit: IMHO string_view::find would be a bit more idiomatic here.
| @@ -76,15 +76,10 @@ int test_persistent_cache() { | |||
| // CHECK: [kernel_compiler Persistent Cache]: cache miss: [[KEY1:.*]] | |||
| // CHECK: [kernel_compiler Persistent Cache]: storing device code IR: {{.*}}/[[KEY1]] | |||
| exe_kb kbExe1a = syclex::build(kbSrc1); | |||
| dumpKernelIDs(); | |||
There was a problem hiding this comment.
Also delete the function, please.
| @@ -775,6 +775,11 @@ class kernel_bundle_impl { | |||
| const std::vector<device> &get_devices() const noexcept { return MDevices; } | |||
|
|
|||
| std::vector<kernel_id> get_kernel_ids() const { | |||
| // RTC kernel bundles shouldn't have user-facing kernel ids, return an | |||
| // empty vector when the bundles contains RTC kernels. | |||
There was a problem hiding this comment.
Suggested change
| // empty vector when the bundles contains RTC kernels. | |
| // empty vector when the bundle was compiled from source. |
| if (!ok) { | ||
| return 0; | ||
| } | ||
| std::string build_log; |
There was a problem hiding this comment.
You can drop the build log to make the test even more compact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL spec mandates that kernel IDs for kernels generated through RTC shouldn't be accessible from the user application. This PR makes it so we filter out the output of
get_kernel_idsso that we behave according to the spec.Removes tests that were relying on kernel_ids being accessible from the user application.