Add ENV overrides & Internal Build Script #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novafacing
changed the title
tklengyel
reviewed
May 9, 2024
brandonmarken
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following environment variables which override provided and default fields of the
[package.metadata.simics]table in theCargo.tomlfile of Simics module crates:This is most useful for cases like the also-added internal build-script, where the package version needs to be changed depending on the Simics version it is compiled against.
Also adds internal build-scripts for compatibility builds and updates all build scripts to directly download Rust instead of using Rustup. This allows for fully offline dockerized builds which makes things easier for people with finnicky VPNs and Proxies.