-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(unplugin-vue-i18n):support vue-i18n v12 #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@babu-ch
Thank you so much!
Before I review your PR, I apologize for not forgetting to tell you an important. 🙇
Currently, vue-i18n-loader, rollup-plugin-vue-i18n, and vite-plugin-vue-i18n already have not been maintained, hot fix only.
So, You would just fix unplugin-vue-i18n only; that’s ok.
packages/unplugin-vue-i18n/README.md
Outdated
@@ -424,23 +424,14 @@ If do you will use this option, you need to enable `jitCompilation` option. | |||
|
|||
For more details, See [here](#-automatic-bundling) | |||
|
|||
### `compositionOnly` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unpluign-vue-i18n options are explained on GitHub README, not website hosting docs.
And, currently, README is covered for all versions.
So, I hope it will be kept on README, and we expect that it will note with GitHub alert syntax that the option will be removed on v7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this okay?
647a438
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just commented at 647a438#r1965726089
packages/unplugin-vue-i18n/README.md
Outdated
|
||
For more details, See [here](https://vue-i18n.intlify.dev/guide/advanced/optimization.html#reduce-bundle-size-with-feature-build-flags) | ||
|
||
> [!NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
CAUTION
is better, not NOTE
. because we want to notice for users strongly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
@babu-ch |
@kazupon Fixed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Thank you so much! 💚
#435