Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(unplugin-vue-i18n):support vue-i18n v12 #436

Merged
merged 9 commits into from
Feb 25, 2025

Conversation

babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Feb 20, 2025

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babu-ch
Thank you so much!

Before I review your PR, I apologize for not forgetting to tell you an important. 🙇

Currently, vue-i18n-loader, rollup-plugin-vue-i18n, and vite-plugin-vue-i18n already have not been maintained, hot fix only.
So, You would just fix unplugin-vue-i18n only; that’s ok.

@babu-ch
Copy link
Contributor Author

babu-ch commented Feb 21, 2025

@kazupon
I've reverted those fixes!
df0d118

@kazupon kazupon added Type: Feature Includes new features Type: Breaking Includes backwards-incompatible fixes Package: unplugin-vue-i18n labels Feb 21, 2025
@kazupon kazupon changed the title support vue-i18n v12 feat!(unplugin-vue-i18n):support vue-i18n v12 Feb 21, 2025
@@ -424,23 +424,14 @@ If do you will use this option, you need to enable `jitCompilation` option.

For more details, See [here](#-automatic-bundling)

### `compositionOnly`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unpluign-vue-i18n options are explained on GitHub README, not website hosting docs.
And, currently, README is covered for all versions.

So, I hope it will be kept on README, and we expect that it will note with GitHub alert syntax that the option will be removed on v7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this okay?
647a438

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just commented at 647a438#r1965726089


For more details, See [here](https://vue-i18n.intlify.dev/guide/advanced/optimization.html#reduce-bundle-size-with-feature-build-flags)

> [!NOTE]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
CAUTION is better, not NOTE. because we want to notice for users strongly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

4f0142f

@kazupon
Copy link
Member

kazupon commented Feb 25, 2025

@babu-ch
webpack sourcemap has been mismatched in CI
we need to fix it!

@babu-ch
Copy link
Contributor Author

babu-ch commented Feb 25, 2025

@kazupon Fixed it!

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
Thank you so much! 💚

@kazupon kazupon merged commit ca82f76 into intlify:main Feb 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: unplugin-vue-i18n Type: Breaking Includes backwards-incompatible fixes Type: Feature Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants